First draft of firestore-basics skill #9719

joehan · 2026-01-08T18:35:24Z

Slightly more polished draft of the firestore-basics skill. It covers:

Provisioning a DB and setting up your firebase.json, rules, and index filkes
Setting up SDKs on each platform, and a bunch of usage examples
A bunch of usage examples of security rules common patterns

TODOs

Add compatibility field that tells agents to instal the CLI if possible
Add more in depth examples to security rules
Add deployment section to provisioning.md
Test and iterate - can we reduce token usage by putting the most basic CUJs directly in SKILL.md?

gemini-code-assist · 2026-01-08T18:35:41Z

Summary of Changes

Hello @joehan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the initial draft of a new 'firestore-basics' skill. Its primary goal is to serve as a comprehensive resource for users looking to understand and implement Cloud Firestore, covering essential aspects from initial setup and configuration to securing data with rules and integrating the SDK into applications.

Highlights

New Firestore Basics Skill: Introduced a new skill named firestore-basics which serves as a comprehensive guide for Cloud Firestore.
Provisioning Guide: Added detailed documentation for setting up Cloud Firestore, covering Firebase CLI initialization, firebase.json configuration, and local emulator usage.
Security Rules Documentation: Provided explanations for Firestore Security Rules, including basic structure, common patterns (locked, test, auth required, user-specific), and deployment instructions.
SDK Usage Examples: Included guidance and code snippets for initializing and using the Firestore Web Modular SDK, connecting to the emulator, and performing basic data operations like adding, reading, and listening for real-time updates.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new 'firestore-basics' skill, providing a foundational guide to Cloud Firestore. The skill is well-structured into provisioning, security rules, and SDK usage. My review includes suggestions to enhance the examples and documentation to make them more practical for users. Specifically, I've recommended improving how data is logged in the SDK examples, adding more advanced security rule patterns like data validation and separated read/write access, and including a section on deploying Firestore configurations. These suggestions align with the TODOs mentioned in the pull request description and aim to make the skill more complete.

skills/firestore-basics/references/provisioning.md

skills/firestore-basics/references/sdk_usage.md

skills/firestore-basics/references/security_rules.md

joehan · 2026-01-09T17:30:51Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new 'firestore-basics' skill, providing comprehensive documentation and code examples for web, Android, and iOS. The content is well-structured and covers key aspects of Firestore, including provisioning, security rules, SDK usage, and indexes. My review focuses on improving the correctness and clarity of the code snippets and documentation. I've identified several issues, such as incorrect API usage in the Android SDK examples, unsafe coding practices like force-unwrapping in Swift, and formatting problems in the markdown files. I've provided specific suggestions to fix these issues, which will enhance the quality and reliability of the skill for developers.

skills/firestore-basics/references/android_sdk_usage.md

skills/firestore-basics/references/security_rules.md

skills/firestore-basics/references/web_sdk_usage.md

skills/firestore-basics/references/android_sdk_usage.md

skills/firestore-basics/references/ios_sdk_usage.md

skills/firestore-basics/references/provisioning.md

skills/firestore-basics/references/web_sdk_usage.md

MichaelDoyle · 2026-01-14T17:58:42Z

@joehan Are the pricing, prompt, and guide changes related to the new skill(s) or are these separate changes? At first glance they seem out of place here. Unless they are just coming from syncing to main? Maybe just do that separately?

MichaelDoyle · 2026-01-14T18:05:30Z

skills/firestore-basics/references/provisioning.md

+
+## Manual Initialization
+
+For non-interactive environments (like AI agents), it is recommended to manually create the necessary configuration files instead of using `firebase init`.


This seems a bit ambiguous. Maybe something like:

Suggested change

For non-interactive environments (like AI agents), it is recommended to manually create the necessary configuration files instead of using `firebase init`.

Initialize the following firebase configuration files manually. Do not use `firebase init` because <reason>.

(insert appropriate <reason>)

What is the reason btw? :)

Good call. is 'becuase it expects interactive inputs, and those will confuse you Mr. AI agent'

joehan · 2026-01-15T00:20:00Z

@joehan Are the pricing, prompt, and guide changes related to the new skill(s) or are these separate changes? At first glance they seem out of place here. Unless they are just coming from syncing to main? Maybe just do that separately?

Yep, those are just from syncing to main (and forgetting to sync launch.skills) - will get the launch branch up to date before merging

First draft of firestore-basics skill

1890f07

gemini-code-assist bot reviewed Jan 8, 2026

View reviewed changes

skills/firestore-basics/references/provisioning.md Show resolved Hide resolved

skills/firestore-basics/references/sdk_usage.md Outdated Show resolved Hide resolved

skills/firestore-basics/references/security_rules.md Show resolved Hide resolved

joehan added 4 commits January 8, 2026 10:44

Merge remote-tracking branch 'origin/main' into jh-skills

fc43ff9

Second pass, with more detail

869d13f

More skill improvements

1535b51

Merge branch 'main' into jh-skills

2a821b6

joehan marked this pull request as ready for review January 9, 2026 17:30

gemini-code-assist bot reviewed Jan 9, 2026

View reviewed changes

joehan added 3 commits January 9, 2026 09:37

Omit skills from prettier

c5937b4

PR fixes

766970a

Merge branch 'main' into jh-skills

448aab3

joehan requested a review from MichaelDoyle January 13, 2026 19:40

Merge branch 'main' into jh-skills

e31f176

joehan changed the base branch from main to launch.skills January 13, 2026 19:40

joehan added 2 commits January 14, 2026 09:48

Merge remote-tracking branch 'origin' into jh-skills

278b296

merging in main

5f0dd48

MichaelDoyle approved these changes Jan 14, 2026

View reviewed changes

incorporating the rules gen strategy developed by the access team

028ae5f

PR fixes

428fe19

joehan merged commit bb01d4b into launch.skills Jan 15, 2026
23 checks passed

joehan deleted the jh-skills branch January 15, 2026 00:30


		## Manual Initialization

		For non-interactive environments (like AI agents), it is recommended to manually create the necessary configuration files instead of using `firebase init`.

	For non-interactive environments (like AI agents), it is recommended to manually create the necessary configuration files instead of using `firebase init`.
	Initialize the following firebase configuration files manually. Do not use `firebase init` because <reason>.

First draft of firestore-basics skill #9719

First draft of firestore-basics skill #9719

Conversation

joehan commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODOs

Uh oh!

gemini-code-assist bot commented Jan 8, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joehan commented Jan 9, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MichaelDoyle commented Jan 14, 2026

Uh oh!

MichaelDoyle Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

MichaelDoyle Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

joehan Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

joehan commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

joehan commented Jan 8, 2026 •

edited

Loading